Skip to content

Improve package repository case insensitive error handling#1974

Merged
JeanChristopheMorinPerso merged 13 commits intoAcademySoftwareFoundation:mainfrom
BryceGattis:hotfix/create_variant_case_mismatch_handling
Jun 21, 2025
Merged

Improve package repository case insensitive error handling#1974
JeanChristopheMorinPerso merged 13 commits intoAcademySoftwareFoundation:mainfrom
BryceGattis:hotfix/create_variant_case_mismatch_handling

Conversation

@BryceGattis
Copy link
Contributor

@BryceGattis BryceGattis commented May 15, 2025 •
edited
Loading

Remake of the original PR #1951 on my personal GitHub.

Closes #1931.

This adds a new unit test for the fix as well.

@BryceGattis
Add failing test case
011b52f 
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
@BryceGattis BryceGattis requested a review from a team as a code owner May 15, 2025 18:59
@BryceGattis
Fix flake8 issue
4c78a84 
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
@codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.11%. Comparing base (0c4b28f) to head (ebbba37).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
+ Coverage   60.07%   60.11%   +0.04%     
==========================================
  Files         163      163              
  Lines       20096    20098       +2     
  Branches     3493     3494       +1     
==========================================
+ Hits        12072    12082      +10     
+ Misses       7208     7205       -3     
+ Partials      816      811       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BryceGattis
Add fix for the lack of error handling
58fcb61 
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso mentioned this pull request May 15, 2025
Closed
JeanChristopheMorinPerso
JeanChristopheMorinPerso reviewed May 15, 2025
View reviewed changes
@BryceGattis @JeanChristopheMorinPerso
Update src/rez/tests/test_package_respository.py
d0daca8 
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>
Signed-off-by: Bryce Gattis <36783788+BryceGattis@users.noreply.github.com>
JeanChristopheMorinPerso
JeanChristopheMorinPerso reviewed May 15, 2025
View reviewed changes
@BryceGattis @JeanChristopheMorinPerso
Update src/rez/tests/test_package_respository.py
3c68222 
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>
Signed-off-by: Bryce Gattis <36783788+BryceGattis@users.noreply.github.com>
@BryceGattis
Copy link
Contributor Author

BryceGattis commented May 15, 2025 •
edited
Loading

@JeanChristopheMorinPerso One thing that I could use some help on, from poking around, I expected that adding this new test file would allow me to do rez selftest --package_repository however, I just get:

rez selftest --package_repository
usage: rez [-h] [-i] [-V] [-v] COMMAND ...
rez: error: unrecognized arguments: --package_repository

Looking at selftest, it should be autogenerated as a new flag. Do you have any idea why it's not working?

@JeanChristopheMorinPerso
Copy link
Member

JeanChristopheMorinPerso commented May 15, 2025

@BryceGattis They should appear in rez-selftest if you add a top level docstring if I'm not mistaken.

@BryceGattis
Copy link
Contributor Author

BryceGattis commented May 15, 2025

@BryceGattis They should appear in rez-selftest if you add a top level docstring if I'm not mistaken.

It was due to a typo in the filename 🤦

@BryceGattis
Fix name of new test file
98f5d75 
Signed-off-by: BryceGattis <brycegattis@yahoo.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso added the devdays25 ASWF Dev Days 2025 label May 19, 2025
@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Jun 21, 2025
@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Package repository case insensitive error handling #2 Package repository case insensitive error handling Jun 21, 2025
@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Package repository case insensitive error handling Improve package repository case insensitive error handling Jun 21, 2025
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit dac6bcb into AcademySoftwareFoundation:main Jun 21, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanChristopheMorinPerso JeanChristopheMorinPerso JeanChristopheMorinPerso left review comments

Assignees

No one assigned

Labels

devdays25 ASWF Dev Days 2025

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

rezplugins\package_repository\filesystem.py failing on Windows when looking for a package family with mismatching case.

2 participants

@BryceGattis @JeanChristopheMorinPerso